New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: check git version #11687
test: check git version #11687
Conversation
Co-authored-by: Rhys Arkins <rhys@arkins.net>
Hi @RahulGautamSingh, I see you're hard at work on your first PR! 😄 ❤️ Did you know that you can close a issue automatically with your PR? Quote from GitHub docs:
Read the GitHub docs, using keywords in issues and pull requests to learn more, and to see the full list of valid keywords. Also the PR title needs a small fix, you need to put a space between |
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs prettier-fix run 🙃
I will pull it and commit again now. |
Head branch was pushed to by a user without write access
Should I make it ready for review now, |
🎉 This PR is included in version 27.8.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
Added an esm
js
file to check git version for compatibility. If found not compatible it will prevent unit testing.Context:
PR created to solve the issue #11167 during tests only
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via:
I wanted to ask how workflow testing works, cause when I run the workflow then the tests on different OS run, and then lint runs separately, so how is the checking on all three OS happening, I do not get that.